fix: c# on windows, oracledb test connection, cli for C# and Oracle DB

[wendrul]

Important

Enhance C# and OracleDB support by updating script extensions, execution, and CLI functionalities, and improve OracleDB test connection handling.

• Behavior:
  • Change OracleDB script extension from oracle.sql to odb.sql in workspaces_export.rs and script.ts.
  • Add C# script execution support in csharp_executor.rs, including error handling and result writing.
  • Update OracleDB test connection query in TestConnection.svelte to SELECT 1 FROM DUAL.
• CLI:
  • Add C# and OracleDB support in script_common.ts, metadata.ts, and sync.ts.
  • Add C# script bootstrap code in script_bootstrap.ts.
• WASM:
  • Add parse_csharp and parse_oracledb functions in windmill_parser_wasm.generated.js and windmill_parser_wasm.generated.d.ts.

^{This description was created by for 7e0ddd6. It will automatically update as commits are pushed.}

[cloudflare-workers-and-pages]

Deploying windmill with    Cloudflare Pages

Latest commit:	80f6587
Status:	⚡️  Build in progress...

View logs

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 2c680d4 in 1 minute and 4 seconds

More details

• Looked at 689 lines of code in 11 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. frontend/src/lib/components/TestConnection.svelte:54

• Draft comment:
  The change to SELECT 1 FROM DUAL for OracleDB is correct and necessary for compatibility with Oracle databases.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The code in TestConnection.svelte for OracleDB has been updated to use SELECT 1 FROM DUAL, which is correct for Oracle databases. This change is consistent with Oracle's requirement to select from a table, even if it's a dummy table like DUAL.

Workflow ID: wflow_S9rSLRwLOyqNJCYW

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 7e0ddd6 in 2 minutes and 3 seconds

More details

• Looked at 710 lines of code in 12 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. backend/windmill-api/src/workspaces_export.rs:358

• Draft comment:
  The change from 'oracle.sql' to 'odb.sql' is consistent across the codebase, ensuring uniformity in file extensions for OracleDB scripts. This change is reflected in multiple files, including script.ts, script_common.ts, and sync.ts. The change is appropriate and aligns with the intent of the PR.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The change from 'oracle.sql' to 'odb.sql' is consistent across the codebase, ensuring uniformity in file extensions for OracleDB scripts. This change is reflected in multiple files, including script.ts, script_common.ts, and sync.ts. The change is appropriate and aligns with the intent of the PR.

2. backend/windmill-worker/src/csharp_executor.rs:290

• Draft comment:
  The addition of error handling in the C# executor is a good practice. It ensures that unhandled exceptions are caught and logged, preventing the application from crashing silently. This change is beneficial for debugging and maintaining the application.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The addition of error handling in the C# executor is a good practice. It ensures that unhandled exceptions are caught and logged, preventing the application from crashing silently. This change is beneficial for debugging and maintaining the application.

3. backend/windmill-worker/src/csharp_executor.rs:341

• Draft comment:
  The addition of the '-p:IncludeNativeLibrariesForSelfExtract=true' flag in the build command for C# projects is a good practice. It ensures that native libraries are included in the self-extracting executable, which is necessary for the application to run correctly on different environments.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The addition of the '-p:IncludeNativeLibrariesForSelfExtract=true' flag in the build command for C# projects is a good practice. It ensures that native libraries are included in the self-extracting executable, which is necessary for the application to run correctly on different environments.

Workflow ID: wflow_53X6Iacqn1eomJ5v

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.