Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #6, integrated cobra cli #8

Merged
merged 6 commits into from
Nov 16, 2023
Merged

resolves #6, integrated cobra cli #8

merged 6 commits into from
Nov 16, 2023

Conversation

tobigiwa
Copy link
Contributor

@tobigiwa tobigiwa commented Nov 12, 2023 •
edited
Loading

resolves #6

@tobigiwa
restructured the codebase to account for the cobra-cli library,
64baf4d 
the cmd/root.go src that invokes the TUI is now relegated to be summoned
by a cobra command. This implies that the default behaviour of the
program are the cobra commands.

Signed-off-by: tobigiwa <[email protected]>
@tobigiwa
added the cobra library (github.com/spf13/cobra) and initialised cobra
77b15fa 
command (cobra-cli init). Included a file license and asciiArt text file.

Signed-off-by: tobigiwa <[email protected]>
@tobigiwa
cobra launch command for bubbletea TUI.
8d9237d 
included the launch cobra commad to display the TUI bubbletea view.
Modified cmd/root.go and included file license.

Signed-off-by: tobigiwa <[email protected]>
@tobigiwa
copied LICENSE from branch "develop"
248387e 
i think cobra might have cleared it.

Signed-off-by: tobigiwa <[email protected]>
@tobigiwa
Copy link
Contributor Author

@wingkwong would you prefer i squash the commit?

@tobigiwa tobigiwa changed the title resolves #6, integrated cobra cli resolves #4, integrated cobra cli Nov 12, 2023
@tobigiwa tobigiwa changed the title resolves #4, integrated cobra cli resolves #6, integrated cobra cli Nov 12, 2023
@tobigiwa
resolves wingkwong#6
17ffc81 
Signed-off-by: tobigiwa <[email protected]>
wingkwong
wingkwong reviewed Nov 16, 2023
View reviewed changes
Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We already got license in the project. Hence I think we don't need to include the copyright block in every file.

@tobigiwa
Copy link
Contributor Author

@wingkwong OK, on it.

@tobigiwa
Resolves wingkwong#6
ae6ac7e 
removed license from .go files

Signed-off-by: tobigiwa <[email protected]>
@wingkwong wingkwong merged commit 26524a1 into wingkwong:develop Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wingkwong wingkwong wingkwong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: integrate with cobra
2 participants
@tobigiwa @wingkwong