Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LAST to LibreSplit #42

Merged
merged 11 commits into from
Jun 2, 2024
Merged

Rename LAST to LibreSplit #42

merged 11 commits into from
Jun 2, 2024

Conversation

wins1ey
Copy link
Owner

@wins1ey wins1ey commented Apr 9, 2024

LAST is going to be renamed to LibreSplit. A lot of functions and variables have last in their name and are going to be renamed to something more sensible for a more readable codebase.

@Loomeh
Copy link
Collaborator

Loomeh commented Apr 9, 2024

Since this seems like a good time to do it, would it be possible to add a prefix to all LibreSplit Lua functions?

For example, readAddress() -> ls_readAddress() or something like that.

I think it would be better to visibly seperate LibreSplit functions from regular Lua functions.

@wins1ey
Copy link
Owner Author

wins1ey commented Apr 11, 2024

Since this seems like a good time to do it, would it be possible to add a prefix to all LibreSplit Lua functions?

I'm not opposed to this but I think it should probably be it's own PR.

@wins1ey wins1ey marked this pull request as ready for review June 2, 2024 20:44
@wins1ey wins1ey merged commit a260630 into main Jun 2, 2024
2 checks passed
@wins1ey wins1ey deleted the libresplit branch June 3, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants