Theme fixes and enhancements #2231
Open
+2,334
−623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Advanced options menu Reset added
DartVanya
force-pushed
the
master-dm
branch
2 times, most recently
from
948cc39
to
b3231d7
Compare
Credits to https://github.com/SFTRS/DarkTaskDialog - Highlighting and Graph colors: menu - Reset added - Fix drawing of disabled ListView in dark theme - SysLink theme support (call PhInitializeSysLinkTheme to apply to control)
- Removed ListView subclass - Add options: EnableThemeAnimation (default 1), EnableThemeNativeButtons (default 0)
- Fix the annoying white border what remained from the previous active control in CHECKLIST_ACLUI - ExtendedServices: MessageBox to TaskDialog transit
- Remove PhInitializeSysLinkTheme
|
@DartVanya |
Yes, it already fixed. See after.mp4 near the end. |
dmex
reviewed
Nov 4, 2024
| PhShowWarning( | ||
| NULL, | ||
| PhShowWarning2( | ||
| GetDesktopWindow(), |
There was a problem hiding this comment.
Why is GetDesktopWindow() used as the parent window?
| @@ -1445,10 +1452,16 @@ VOID PhpProcessStartupParameters( | |||
| NULL | |||
| ) || PhStartupParameters.Help) | |||
| { | |||
| PhShowInformation( | |||
| NULL, | |||
| if (PhStartupParameters.Help) | |||
There was a problem hiding this comment.
Why does this delete the -help command and replace the code with UI initialization?
| @@ -292,7 +292,7 @@ INT_PTR CALLBACK OptionsDlgProc( | |||
|
|
|||
| for (LONG i = numberOfItems - 1; i >= 0; i--) | |||
| { | |||
| PhRemoveListViewItem(listviewHandle, i); | |||
| PhRemoveListViewItem(listviewHandle, PhFindListViewItemByParam(listviewHandle, INT_ERROR, listviewItems[i])); | |||
There was a problem hiding this comment.
this is searching for the index of an item when we already have the index?
- TaskDialog theme on Windows 10 currently unsupported...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full DarkMode support for TaskDialog
Credits to https://github.com/SFTRS/DarkTaskDialog
Public PhThemeWindowDrawButton: support tristate checkbox, radio, multiline label.
Apply DarkMode_Explorer theme for all checkboxes (even for ListView checks), radio and buttons.
Fix artefacts on GroupBox and Static picture controls when window moving back from off-screen.
TreeNew: significantly improve visibility of selected item.
ExtListVew: fix text readability for hot and selected colored items.
Fix drawing of disabled ListView in dark themeHide ListVIew on Graph settings page instead of disabling.Fix multiline edit artifacts when typing, fix scrollbar.
Fix dark theme for new choose dialog.
Fix dark ListView header in unsupported system dialogs (skip superclass drawing).
Better ListView theme (DarkMode_ItemsView and OpenNcThemeData hook for scrollbars).
Add borders to TabControl header and body, selected tab slightly enlarged (behaves like default MS white theme).
Add separators for StatusBar parts for better readability.
SysLink theme support.
Security page CHECKLIST_ACLUI checks theme support and other improvements.
Add new theme options: EnableThemeAnimation (default 1), EnableThemeNativeButtons (default 0).
All changes highlighted on video:
before.mp4
after.mp4
taskdialog-dm.mp4
colors-menu-reset.mp4