Revert "fix: set default type to "internal" if it's somehow missing (#10

)" (#16) This reverts commit 4f9ec69.
winteragency · Jun 7, 2024 · 43d4cc0 · 43d4cc0
1 parent 3ae5583
commit 43d4cc0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/src/components/LinkTypeInput.tsx b/src/components/LinkTypeInput.tsx
@@ -53,13 +53,6 @@ export function LinkTypeInput({
 
   const selectedType = linkTypes.find((type) => type.value === value) || linkTypes[0]
 
-  useEffect(() => {
-    // Make sure there's always a default value
-    if (!value) {
-      onChange(set('internal'))
-    }
-  }, [onChange, value])
-
   return (
     <MenuButton
       button={

diff --git a/src/helpers/typeGuards.ts b/src/helpers/typeGuards.ts
@@ -16,4 +16,4 @@ export const isEmailLink = (link: LinkValue): link is EmailLink => link.type ===
 export const isPhoneLink = (link: LinkValue): link is PhoneLink => link.type === 'phone'
 
 export const isCustomLink = (link: LinkValue): link is CustomLink =>
-  !!link.type && !['internal', 'external', 'email', 'phone'].includes(link.type)
+  !['internal', 'external', 'email', 'phone'].includes(link.type)