properly handle empty TagList formwidget

wintercms · Dec 10, 2024 · 8e54454 · 8e54454
1 parent 47307c7
commit 8e54454
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/modules/backend/formwidgets/TagList.php b/modules/backend/formwidgets/TagList.php
@@ -131,6 +131,8 @@ protected function hydrateRelationSaveValue($names): ?array
             $names = [$names];
         }
 
+        $names = array_filter($names);
+
         $relation = $this->getRelationObject();
         $relationModel = $this->getRelationModel();
 

diff --git a/modules/backend/formwidgets/taglist/partials/_taglist.php b/modules/backend/formwidgets/taglist/partials/_taglist.php
@@ -33,6 +33,7 @@
             value="<?= $field->value ?>">
     <?php endif ?>
 <?php else: ?>
+    <input type="hidden" name="<?= $field->getName() ?>[]">
     <select
         id="<?= $field->getId() ?>"
         name="<?= $field->getName() ?>[]"

diff --git a/modules/backend/widgets/Form.php b/modules/backend/widgets/Form.php
@@ -1227,11 +1227,7 @@ public function getSaveData(): array
             // Exclude fields that didn't provide any value
             $fieldValue = $this->dataArrayGet($result, $parts, FormField::NO_SAVE_DATA);
             if ($fieldValue === FormField::NO_SAVE_DATA) {
-                if ($widget->getConfig('type') === 'taglist') {
-                    $fieldValue = [];
-                } else {
-                    continue;
-                }
+                continue;
             }
 
             // Exclude fields where the widget returns NO_SAVE_DATA