Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant backend route #1258

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Remove redundant backend route #1258

merged 2 commits into from
Dec 7, 2024

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Nov 27, 2024

I tested this on nginx and apache on both Laravel 9 and Laravel 11 by making sure the route cache was cleared.

No issues so far.

@mjauvin mjauvin added maintenance PRs that fix bugs, are translation changes or make only minor changes needs review Issues/PRs that require a review from a maintainer labels Nov 27, 2024
@mjauvin mjauvin added this to the 1.2.8 milestone Nov 27, 2024
@mjauvin mjauvin self-assigned this Nov 27, 2024
@LukeTowers
Copy link
Member

@mjauvin does this still work if backendUri is set to an empty string? ''

@mjauvin
Copy link
Member Author

mjauvin commented Nov 27, 2024

@mjauvin does this still work if backendUri is set to an empty string? ''

Yes, that works too.

Co-authored-by: Ben Thomson <[email protected]>
@mjauvin
Copy link
Member Author

mjauvin commented Dec 7, 2024

@LukeTowers care to merge this so we can test it in develop at a larger scale before we release 1.2.8 ?

@LukeTowers LukeTowers removed the needs review Issues/PRs that require a review from a maintainer label Dec 7, 2024
@LukeTowers LukeTowers merged commit a7f9ce5 into develop Dec 7, 2024
13 checks passed
@LukeTowers LukeTowers deleted the remove-route-redundancy branch December 7, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants