Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java-jar.md #233

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Update java-jar.md #233

merged 1 commit into from
Dec 8, 2023

Conversation

orcunbalcilar
Copy link
Contributor

@orcunbalcilar orcunbalcilar commented Dec 5, 2023

'wiremock' phrase leads to a misunderstanding. Because the usage -> 'wiremock' is not valid in command line. And in this case while wiremock server is up, user is getting no mapping found error when (s)he has made an http call. Perhaps user should know 'wiremock' usage is invalid in command line. But I have spent four hours to figure it out because I was tired. :)

References

  • TODO

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • If the change against WireMock 2 functionality (incompatible with WireMock 3),
    it is submitted against the 2.x branch
  • The repository's code style is followed (see the contributing guide)

Details: Contributor Guide

'wiremock' phrase leads to a misunderstanding. Because the usage -> 'wiremock' is not valid in command line. And in this case while wiremock server is up, user is getting no mapping found error when (s)he has made an http call. Perhaps user should know 'wiremock' usage is invalid in command line. But I have spent four hours to figure it out because I was tired. :)
@orcunbalcilar
Copy link
Contributor Author

Hi @oleg-nenashev,
Could you please review my pull request?

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thanks!

@oleg-nenashev oleg-nenashev added the bug Something isn't working label Dec 8, 2023
@oleg-nenashev oleg-nenashev merged commit 196bfb7 into wiremock:main Dec 8, 2023
1 check passed
@orcunbalcilar
Copy link
Contributor Author

Thank you too 😊👍

@orcunbalcilar orcunbalcilar deleted the patch-1 branch December 9, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants