fix(container): compiling error with pnpm #12934
Merged
+73
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #12669
Closes PLT-2733
The main issue was that the astro container runtime was pulling
vite
code, which is a forbidden behaviour. I managed, somehow, to understand that the code that was pullingvite
code was coming frommanifest/create.ts
, so one of its modules (or modules of modules) was imported, eventually importing a runtimevite
function.Unfortunately, I couldn't understand what's the culprit, so instead, I decided to move the functions needed by the container into two separate files.
Also, I tried to remove any occurrence of
normalizePath
fromvite
, and used our internal version, which is the same. That should reduce these mistakes in the future.Testing
I used the production provided, which I didn't build. Now it builds
Docs
N/A