Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete old entry when frontmatter slug changed #12966

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Jan 10, 2025

Changes

While the glob loader handles deleting or renaming a file, it didn't previously handle the scenario where a slug was changed inside a file. This PR ensures that the old entry is deleted.

Fixes #12668

Testing

Adds new test cases

Docs

Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: ab05a29

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 10, 2025
Copy link

codspeed-hq bot commented Jan 10, 2025

CodSpeed Performance Report

Merging #12966 will not alter performance

Comparing cleanup-slug (ab05a29) with main (f00c2dd)

Summary

✅ 6 untouched benchmarks

@ascorbic ascorbic merged commit d864e09 into main Jan 10, 2025
16 checks passed
@ascorbic ascorbic deleted the cleanup-slug branch January 10, 2025 15:12
@astrobot-houston astrobot-houston mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing slug in a content entry results in duplicate entry until dev server is restarted
3 participants