fix(i18n): fallback should create consistent directories #9142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 972799b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
github-actions
bot
added
the
pr: docs
matthewp
approved these changes
Nov 20, 2023
Merged
ematipico
added a commit
that referenced
this pull request
Nov 21, 2023
…)" This reverts commit 7d55cf6.
ematipico
added a commit
that referenced
this pull request
Nov 21, 2023
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
ematipico
added a commit
that referenced
this pull request
Nov 30, 2023
ematipico
added a commit
that referenced
this pull request
Nov 30, 2023
* add test case * fix(i18n): fallback should create consistent directories (#9142) * fix: index can be 0!! * tests should have the correct configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #9096
Fixes #9095
Closes PLT-1230
This PR refactors the fallback system again. There was a business logic flaw in how the routes and paths were computed, plus the flow of things could have been smoother, and that didn't help.
When rendering a page, the flow was like this:
getStaticPathsgeneratePathfunctionNow the flow is adapted to the fallback, and a few steps have been moved:
generatePathfunctionThe function
generatePathnow accepts the styles/scripts/links, and they are already computed; it only needs to render theResponse.The function
eachRouteInRouteDatais now called in a different place and its loop is way smaller.Testing
I added a new test case that should prevent a regression against the issues we're closing.
The rest of the tests should still pass.
Docs
N/A