Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add my two new plugins to Starlight resources/plugins.mdx page #2595

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

trueberryless
Copy link
Contributor

Description

I'm NOT adding Cooler Credit at the end of the list for the following reason:
I think it looks really nice if Starlight Sidebar Topics and Starlight Sidebar Topics Dropdown are next to each other (side-by-side) because the Dropdown version is actually a copy of the original...

Copy link

changeset-bot bot commented Nov 9, 2024

⚠️ No Changeset found

Latest commit: f960bb3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📚 docs Documentation website changes label Nov 9, 2024
Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit f960bb3
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6730d3631dc7d90008116b7d
😎 Deploy Preview https://deploy-preview-2595--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Nov 9, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en resources/plugins.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new additions 🌟

Let's actually move starlight-cooler-credit to the bottom of the list with the other new one and keep a strict append-only approach. Allowing user-defined order once can potentially set a precedent for future requests where a user could just ask "I'd like my plugin to be at the top of the list because its name starts with an 'A'" or any other reason, valid or not. Definitely easier to just keep it simple and potentially avoid any unwanted discussions.

docs/src/content/docs/resources/plugins.mdx Outdated Show resolved Hide resolved
@trueberryless
Copy link
Contributor Author

Okay, should be good to go now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants