Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(railway): verbose/version shorthands #1865

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

aleksrutins
Copy link
Contributor

@withfig-bot
Copy link
Collaborator

withfig-bot commented Feb 20, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@withfig-bot
Copy link
Collaborator

Overview

src/railway.ts:

Info:

@withfig-bot
Copy link
Collaborator

Hello @aleksrutins,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@aleksrutins
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

withfig-bot added a commit that referenced this pull request Feb 20, 2023
@aleksrutins aleksrutins changed the title Fix Railway CLI verbose/version shorthands fix(railway): verbose/version shorthands Feb 20, 2023
Copy link

@nebulatgs nebulatgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on this until CLIv3 is released

@aleksrutins
Copy link
Contributor Author

The previous configuration was incorrect for cliv2 as well, though - the only thing incompatible with v2 in this version is that the --version shorthand.

@fedeci
Copy link
Contributor

fedeci commented Feb 27, 2023

@nebulatgs please ping me when this is ready to be merged!

Copy link
Contributor

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aleksrutins!

@fedeci fedeci merged commit fa06c78 into withfig:master Apr 22, 2023
@withfig withfig locked and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants