-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/2.1.0 #23
Open
guidiaz
wants to merge
7
commits into
witnet:2.1.x
Choose a base branch
from
guidiaz:feat/2.1.0
base: 2.1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/2.1.0 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
reviewed
Dec 24, 2024
|
||
- The **Witnet Radon Typescript** library, for programmatically building Witnet data requests. | ||
- The **Witnet Toolkit** command, for simulating both the resolution steps and the result that witnessing nodes in the Witnet blockchain would obtain if resolving the given data request at the present moment. | ||
Interact with the Wit/Oracle blockchain from Javascript without actually running a node. Build your own Witnet-compliant parameterized data requests and test them before broadcasting sending them to the Witnet network and getting the results forever stored in the Wit/Oracle blockchain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Interact with the Wit/Oracle blockchain from Javascript without actually running a node. Build your own Witnet-compliant parameterized data requests and test them before broadcasting sending them to the Witnet network and getting the results forever stored in the Wit/Oracle blockchain. | |
Interact with the Wit/Oracle blockchain from Javascript without actually running a node. Build your own Witnet-compliant parameterized data requests and test them before broadcasting them to the Witnet network and getting the results forever stored in the Wit/Oracle blockchain. |
Tommytrg
reviewed
Dec 24, 2024
src/index.ts
Outdated
Comment on lines
1
to
2
import * as _RadonRetrievals from "./lib/radon/retrievals" | ||
export const RadonRetrievals: typeof _RadonRetrievals = _RadonRetrievals; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to import it using an underscore because RadonRetrievals
is a class with the RadonRetrievals
type which makes it unnecessary.
Suggested change
import * as _RadonRetrievals from "./lib/radon/retrievals" | |
export const RadonRetrievals: typeof _RadonRetrievals = _RadonRetrievals; | |
// if we aren't using RadonRetrievals in the file so we only want to export it, we can avoid the import line | |
export * as RadonRetrievals from "./lib/radon/retrievals"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #22