Fixes issue #2526 #2527
Open
Fixes issue #2526 #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Sep 18, 2024
| @@ -102,7 +102,8 @@ const CalendarHeader = forwardRef((props: CalendarHeaderProps, ref) => { | |||
| importantForAccessibility, | |||
| numberOfDays, | |||
| current = '', | |||
| timelineLeftInset | |||
| timelineLeftInset, | |||
| accessibilityRole | |||
There was a problem hiding this comment.
Where this prop is declared?
There was a problem hiding this comment.
defined in the props. Did you mean that?
Inbal-Tish
reviewed
Sep 18, 2024
src/calendar/header/index.tsx
Outdated
| @@ -279,7 +280,7 @@ const CalendarHeader = forwardRef((props: CalendarHeaderProps, ref) => { | |||
| testID={testID} | |||
| style={propsStyle} | |||
| accessible | |||
| accessibilityRole={'adjustable'} | |||
| accessibilityRole={accessibilityRole} | |||
There was a problem hiding this comment.
You're removing the existing value without even set it as the default...
There was a problem hiding this comment.
added fallback value to "adjustable"
|
@Abhisflyingsoon Thank you for the PR. Please add a description to summarize the issue and your solution to it. |
- Add typing for accessibilityRole prop - Add fallback to accessibilityRole
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue of the hardcoded accessbilityRole issue in the header component. It was causing problem with the Voicover/Talkback Screenreader functionality, it was suggesting wrong accessbilityActions when the header was in focus.