FIX: Enable nestedScrollEnabled prop for Android api level 21+ #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling on android api 21+
av3n93rz
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new prop to Timeline to enable nested scrolling.
I was trying to add the pull to refresh feature to a wrapper ScrollView on my calendar and noticed that I can not enable nested scrolling for the android devices.
This creates an unwanted behaviour where you are unable to swip downwards (scroll up) without triggering the pull to refresh feature.
Without adding this prop to the Timeline's ScrollView the only way to scroll up is to start scrolling down then changing direction while still touching the screen.
Current behaviour:
https://github.com/user-attachments/assets/1e365832-0ac7-413a-991f-a148f1dc5726
Expected behaviour:
https://github.com/user-attachments/assets/56f8be5a-3d3f-4ec0-8e12-36628abed9da