Add support for unit testing multiple extensions #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnson
reviewed
Jul 22, 2023
| @@ -46,10 +57,13 @@ public string[] BuildAndQuery(Action<string[]> buildFunc, bool validate, params | |||
| "-intermediateFolder", intermediateFolder, | |||
| }; | |||
|
|
|||
| if (this.ExtensionType != null) | |||
| if (null != this.ExtensionType) | |||
There was a problem hiding this comment.
Yoda comparisons aren't needed in managed code. (They're still officially style for WiX C code, however.)
There was a problem hiding this comment.
thanks for the tip
barnson
reviewed
Jul 22, 2023
| this.OutputFile = outputFile ?? "test.msi"; | ||
| } | ||
|
|
||
| public Builder(string sourceFolder, Type[] extensionType , string[] bindPaths = null, string outputFile = null) |
barnson
reviewed
Jul 22, 2023
| @@ -18,7 +29,7 @@ public Builder(string sourceFolder, Type extensionType = null, string[] bindPath | |||
|
|
|||
| public string[] BindPaths { get; set; } | |||
|
|
|||
| public Type ExtensionType { get; set; } | |||
| public Type[] ExtensionType { get; set; } | |||
chrisbednarski
force-pushed
the
feat/unit-tests
branch
from
7ca7485
to
6c66dd3
Compare
barnson
approved these changes
Jul 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a constructor that takes an array of types, so integration between multiple extensions can be tested.
Fixed an error that showed up after adding the new constructor, because passing
nullas the 2nd argument was ambiguous.Example package file:
Example unit test file:
