Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for the firewall extenstion #443

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

chrisbednarski
Copy link
Contributor

Examples of the output of a failing test (when the unique check is modified in the verifier self test)

image

image

image

@chrisbednarski
Copy link
Contributor Author

Is this heading in the right direction?

Is there anything I can do to help get this in or across the line?

What WiX version do you think firewall CA changes could be made in (after more integration tests have been added for the existing firewall CA functionality)?

@chrisbednarski
Copy link
Contributor Author

chrisbednarski commented Aug 16, 2023

There is a substantial amount of code in the firewall CA for adding firewall rules on Windows XP and possibly prior to XP.
This is impossible to test on a newer OS without making changes to the CA.

Since Windows XP support ended a long time ago, should/can this be removed when making major changes in the future?

@barnson
Copy link
Member

barnson commented Aug 16, 2023

At first glance, it looks like what I'd expect to see. I'll take a closer look, probably this weekend.

XP support is dead-dead so especially if there's extra code to keep it running, nuke it from orbit.

The next feature release for WiX is v5 in the develop branch. v4.0.2 is for high-pri bug fixes only.

@barnson barnson merged commit febb9c9 into wixtoolset:develop Aug 19, 2023
2 checks passed
@barnson
Copy link
Member

barnson commented Aug 19, 2023

Very cool, thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2023
@chrisbednarski chrisbednarski deleted the feat/firewall-tests branch August 19, 2023 23:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants