firewall extension cross version integration test #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbednarski
force-pushed
the
feat/cross-version-test
branch
from
7268899
to
bd042f7
Compare
|
this one can be closed, because it's included in #431 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes #451
Hope this will be useful for the table name change triage
the PR creates an msi package with two modules
Module401(4.0.1)ModuleCurrent(5.0.0 preview)Because the msi itself contains two firewall rules, I had to suppress the warnings that were triggered by the CA of
ModuleCurrentThe integration test installs the msi, verifies all the added firewall exceptions, then uninstalls them