gui: disable replacement fee input if tx is already replaced #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nondiremanuel
added
the
Nice to have
jp1ac4
reviewed
Jul 22, 2024
| /// It expects: | ||
| /// - a placeholder | ||
| /// - the current value | ||
| pub fn new_disabled(placeholder: &str, value: &Value<String>) -> Self { |
There was a problem hiding this comment.
Perhaps instead of adding this method, you could reuse the new() method by changing the on_change parameter to Option.
What do you think, @edouardparis?
There was a problem hiding this comment.
I had a couple of further thoughts:
- Unrelated to this PR (perhaps could be a separate commit), we could refactor the
new_trimmed()andnew_amount_btc()methods to callSelf::new()with the modifiedon_changeparameter. - If these other methods also use
Option, then you can use thenew_trimmed()whether or not the replacement txid exists, and the only thing that will change is whether you passNoneorSometo theon_changeparameter (rather than different methods being called in each case).
There was a problem hiding this comment.
We can have new_disabled for now. I prefer we keep the change small.
|
Moving this and the relative issue to v8 since as per team discussion we won't be able to properly review and test it given the close deadline. |
nondiremanuel
modified the milestones:
v9 Liana - Candidates,
v9 Liana - UI fixes and other
nondiremanuel
modified the milestones:
v9 Liana - UI fixes and other,
v10 Liana - UI fixes and other activities
|
ping @edouardparis |
|
I just answered here, if it was the reason of your ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR disable input on feerate TextInput if the tx already have been replaced, it's fine to do so because we still can RBF the new replacing tx.
close #1138