electrum: ping server before returning client

[jp1ac4]

Ping server as an extra connectivity check.

[jp1ac4]

I haven't been able to reproduce the test failures on my local machine. Still investigating.

[darosior]

lianad logs for CI failure:

b"[1725971004][liana][INFO][thread main] Created a new data directory at '/tmp/lianad-tests-5getftrr/test_coinbase_deposit_1/lianad/regtest'"
b'[1725971004][liana::database::sqlite][INFO][thread main] Created a fresh database at /tmp/lianad-tests-5getftrr/test_coinbase_deposit_1/lianad/regtest/lianad.sqlite3.'
b'[1725971004][liana::database::sqlite][INFO][thread main] Checking if the database needs upgrading.'
b'[1725971004][liana][INFO][thread main] Database initialized and checked.'
b'[1725971004][electrum_client::raw_client][INFO][thread main] Trying to connect to 127.0.0.1:39451 (attempt 1/1) with timeout 3s'
b'[1725971004][lianad][ERROR][thread main] Error starting Liana daemon: Error setting up Electrum interface: \'Electrum client error: \'Electrum error: \'Electrum server error: {"code":-32603,"message":"unavailable index"}\'.\'.\'.'

[darosior]

Please don't re-push just now, i'm trying to debug on Cirrus. Also, we should address the root cause of the issue, not just throw more retries until it passes CI.

[jp1ac4]

lianad logs for CI failure:

Thanks 🙏

Please don't re-push just now, i'm trying to debug on Cirrus. Also, we should address the root cause of the issue, not just throw more retries until it passes CI.

I agree. We probably need to look for something else in the logs when starting electrs to consider it ready to receive the ping request.

[darosior]

Yes, that's what i'll be looking for once my "re-run with Terminal access" is done re-running.

…

On Tuesday, September 10th, 2024 at 2:40 PM, Michael Mallan ***@***.***> wrote: > lianad logs for CI failure: Thanks 🙏 > Please don't re-push just now, i'm trying to debug on Cirrus. Also, we should address the root cause of the issue, not just throw more retries until it passes CI. I agree. We probably need to look for something else in the logs when starting electrs to consider it ready to receive the ping request. — Reply to this email directly, [view it on GitHub](#1282 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3FY2HX4LFOTYJ73SVT3ZV3SEJAVCNFSM6AAAAABNYWT3XCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBQGYZDANJUGA). You are receiving this because you commented.Message ID: ***@***.***>

[darosior]

So we want Electrs to not start until its index has is_ready set to true. Helpfully, they don't log anything when they actually set it to true.

Maybe waiting for finished full compaction could be a good enough approximation. But a robust alternative would be to simply (Electrum-)ping the server until it replies with a proper pong (to be clear: in the Python framework, not in the software).

[darosior]

We could let the more robust solutions as a followup.

[darosior]

utACK 537ebb2