Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui: add help text for electrum address #1344

Merged
merged 1 commit into from
Sep 16, 2024
Merged

gui: add help text for electrum address #1344

merged 1 commit into from
Sep 16, 2024

Conversation

jp1ac4
Copy link
Collaborator

@jp1ac4 jp1ac4 commented Sep 16, 2024

This adds a short text explanation about SSL usage in Electrum addresses to both the installer and settings page.

This is a modified version of #1342.

@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Sep 16, 2024

Here's how it looks in the installer:

image

And on the settings page (only when editing connection):

image

@nondiremanuel nondiremanuel added this to the v7 - Liana milestone Sep 16, 2024
@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Sep 16, 2024

I could put the text below the input form, e.g.:

image

image

@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Sep 16, 2024

For the installer:

image

image

@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Sep 16, 2024

Moved the text below address input form.

edouardparis
edouardparis approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0084163

@edouardparis edouardparis merged commit 47fb6ef into wizardsardine:master Sep 16, 2024
31 checks passed
@jp1ac4 jp1ac4 mentioned this pull request Sep 16, 2024
Merged
edouardparis added a commit that referenced this pull request Sep 16, 2024
@edouardparis
Merge #1345: backport for v7: gui: add help text for electrum address
38377c8 
89d1507 gui: add help text for electrum address (Michael Mallan)

Pull request description:

  backport of #1344.

ACKs for top commit:
  edouardparis:
    ACK 89d1507

Tree-SHA512: ebbd5372bbbf465b5c35c6058d698bb9ce9346b89376b7c124335255b324ed52bf68689e98e1cd34612748ef61cab0d751d7cb8f8c565d2a9a019706fd5fe9b9
@jp1ac4 jp1ac4 deleted the electrum-ssl-error-msg branch September 16, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edouardparis edouardparis edouardparis approved these changes

Assignees

@jp1ac4 jp1ac4

Labels
None yet
Projects
Liana General
Status: Done
Milestone
v7 - Liana
Development

Successfully merging this pull request may close these issues.
3 participants
@jp1ac4 @edouardparis @nondiremanuel