Add templates to installer descriptor editor #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edouardparis
force-pushed
the
refac-edit-xpub-modal
branch
2 times, most recently
from
29a1320
to
41ec55c
Compare
edouardparis
force-pushed
the
refac-edit-xpub-modal
branch
4 times, most recently
from
a4bf658
to
b49de79
Compare
edouardparis
changed the title
edouardparis
force-pushed
the
refac-edit-xpub-modal
branch
2 times, most recently
from
b2f70bc
to
9f0e32f
Compare
edouardparis
force-pushed
the
refac-edit-xpub-modal
branch
3 times, most recently
from
273814c
to
05d6e1e
Compare
|
If I choose the "Custom wallet" option and then click the trash icon next to "Primary key" twice, I get the following error: |
edouardparis
force-pushed
the
refac-edit-xpub-modal
branch
from
0ef2df4
to
0cd79b7
Compare
|
Tested on 0cd79b7: Unlike in v7, the fingerprint is not cleared if I change the signing device: |
jp1ac4
reviewed
Oct 24, 2024
There was a problem hiding this comment.
I think it should be "Receipt of funds" (in both images).
There was a problem hiding this comment.
I updated the figmas with "Receipt".
PS: The updated svgs will be given once the templates and wording discussion will be finalized.
edouardparis
force-pushed
the
refac-edit-xpub-modal
branch
from
0cd79b7
to
c90d9db
Compare
jp1ac4
reviewed
Oct 28, 2024
edouardparis
force-pushed
the
refac-edit-xpub-modal
branch
from
c90d9db
to
294e4ba
Compare
edouardparis
force-pushed
the
refac-edit-xpub-modal
branch
from
71358a6
to
bd03cc9
Compare
edouardparis
commented
Oct 29, 2024
There was a problem hiding this comment.
Self-ACK bd03cc9
Tested multiple time by me and Michael, next iteration should be in an other PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for #1147