[GUI] Skip loading screen for existing wallets #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp1ac4
added this to the v8 Liana - Wallet syncing / scanning state at wallet opening milestone
jp1ac4
force-pushed
the
gui-skip-loader-for-existing-wallets
branch
4 times, most recently
from
37a44ab
to
55680f8
Compare
|
Rebased on #1377. |
jp1ac4
force-pushed
the
gui-skip-loader-for-existing-wallets
branch
from
55680f8
to
91bf35f
Compare
|
Rebased on #1377. |
jp1ac4
force-pushed
the
gui-skip-loader-for-existing-wallets
branch
from
91bf35f
to
7ed09dc
Compare
|
Rebased on #1377. |
jp1ac4
force-pushed
the
gui-skip-loader-for-existing-wallets
branch
5 times, most recently
from
b756138
to
489c7e6
Compare
Use an enum to clearly enumerate the different cases we are considering and avoid the need to repeat logic relating to blockheight in the view.
jp1ac4
force-pushed
the
gui-skip-loader-for-existing-wallets
branch
from
489c7e6
to
0a674d5
Compare
|
Works like a charm. I think have better UX/UI to imagine, but I am happy with the result. |
That's right, it would load the home page directly and show the sync progress as returned by |
|
Ok thank you for the answer, it is not really inconvenient. |
|
ACK 0a674d5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve #1384 by skipping the loading screen for an existing wallet even if the blockchain is still syncing.
This change will only make a difference for local backends given that
the blockchain for a Liana Connect wallet is always considered to be synced and so the loading screen was already loading the application directlyLiana Connect doesn't use the loading screen.It builds on #1377, to additionally check the blockchain sync progress, and show a message with the sync progress as a percentage in case the blockchain is not fully synced.
using the logic added there to indicate on the home page that syncing is in progress if the poller has not yet run. Polling does not start until the blockchain has fully synced and so the same logic can be applied here.For now, no distinction is made on the home page between the wallet syncing and the blockchain syncing, but this may change in future.