Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui(installer): re-add next button when starting managed bitcoind #1417

Conversation

jp1ac4
Copy link
Collaborator

@jp1ac4 jp1ac4 commented Oct 31, 2024

This Next button was accidentally removed in commit bd03cc9.

@edouardparis
Copy link
Member

Good, can you refac this to remove the unecessary Row and use press_maybe ?

This Next button was accidentally removed in commit
bd03cc9.

This re-adds the button with some code refactoring.
@jp1ac4 jp1ac4 force-pushed the gui-installer-revert-managed-bitcoind-change branch from da43d68 to 322597f Compare November 1, 2024 10:28
@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Nov 1, 2024

I refactored the code as suggested.

@pythcoiner
Copy link
Collaborator

pythcoiner commented Nov 1, 2024

tACK 322597f

image

@edouardparis edouardparis merged commit a061d8f into wizardsardine:master Nov 4, 2024
31 checks passed
@jp1ac4 jp1ac4 deleted the gui-installer-revert-managed-bitcoind-change branch November 6, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants