Refresh cache more often in GUI while wallet or blockchain is syncing #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to reuse elsewhere.
Refresh the cache more often while the wallet has a syncing status of some kind in order to detect sooner that this has finished. This does not cover syncing scenarios that require the first poll to be detected since we don't currently store the required info (the last poll at startup). This should be covered in a follow-up.
nondiremanuel
added this to the v8 Liana - Wallet syncing / scanning state at wallet opening milestone
pythcoiner
reviewed
Nov 4, 2024
| // If external daemon, we cannot be sure it will return last poll as it | ||
| // depends on the version, so assume it won't unless the last poll at | ||
| // startup is set. | ||
| // TODO: should we check the daemon version at GUI startup? |
There was a problem hiding this comment.
iirc we assume an user always run a daemon w/ same version as the GUI?
Maybe we should just add a sanity check for this in a separate PR?
There was a problem hiding this comment.
I'll create an issue for that.
There was a problem hiding this comment.
This can be tracked in #1429.
|
tACK 918909d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve #1414.
In the end, I felt it was simple enough to include commits that cover both parts of #1414 (the short-term change and the follow-up).
I start with the short-term change (setting the refresh interval ignoring the last poll logic) and then follow with commits that cover all syncing statuses.
I don't use as high a refresh frequency for a remote backend as for a local backend, but these values can be easily changed if required.