-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gui(installer): apply wording changes to installer templates #1422
gui(installer): apply wording changes to installer templates #1422
Conversation
I still need to:
|
Here the sentence is not exactly the one requested:
|
|
I would use "setup" for consistency with the other introduction pages. |
nit2: i'd keep |
Looking at it, I would probably drop the "another", especially when adding a key. It was useful to see how it looks, but I don't think it adds much value compared to the disadvantage of having a word more. |
d6bf9ea
to
f4b4afb
Compare
Oh yes, well spotted :) I changed this to the latter as I think it's more common this way and that's how I kept trying to read it.
I haven't made any changes for this. Shall we move it to a new issue?
SVGs have been updated.
Done.
I dropped the commit that changed the wording of the "Add key" and "Add recovery option" buttons. |
Yes we can manage it as a different UI improvement. |
updated screenshot @ f4b4afb: |
tACK f4b4afb |
f4b4afb
to
9a3bc87
Compare
Rebased on master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9a3bc87
This is to resolve #1418.