Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui(installer): apply wording changes to installer templates #1422

Merged

Conversation

jp1ac4
Copy link
Collaborator

@jp1ac4 jp1ac4 commented Nov 1, 2024

This is to resolve #1418.

@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Nov 1, 2024

I still need to:

  • Update SVGs

@jp1ac4 jp1ac4 changed the title [GUI] Apply wording changes to installer templates gui(installer): apply wording changes to installer templates Nov 1, 2024
@jp1ac4 jp1ac4 self-assigned this Nov 1, 2024
@pythcoiner
Copy link
Collaborator

image

@pythcoiner
Copy link
Collaborator

image

@pythcoiner
Copy link
Collaborator

image

Here the sentence is not exactly the one requested:

Change the first sentence to: "For this setup you will need 2 keys: a Primary Key (for yourself) and an Inheritance Key (for your heir). For security reasons, we suggest you use a separate Hardware Wallet for each key."

setup vs Inheritance wallet, but maybe this is wanted/better?

@pythcoiner
Copy link
Collaborator

pythcoiner commented Nov 4, 2024

image
will be always able vs will always be able but i guess @jp1ac4 is wright

@nondiremanuel
Copy link
Collaborator

Here the sentence is not exactly the one requested:

Change the first sentence to: "For this setup you will need 2 keys: a Primary Key (for yourself) and an Inheritance Key (for your heir). For security reasons, we suggest you use a separate Hardware Wallet for each key."

setup vs Inheritance wallet, but maybe this is wanted/better?

I would use "setup" for consistency with the other introduction pages.

@pythcoiner
Copy link
Collaborator

nit: titles vs texts are not aligned, and it looks to me the title are too close from the radiuses
image

@pythcoiner
Copy link
Collaborator

nit2: i'd keep Add another key & Add another recovery option as i dont think we use + elsewhere

@nondiremanuel
Copy link
Collaborator

Looking at it, I would probably drop the "another", especially when adding a key. It was useful to see how it looks, but I don't think it adds much value compared to the disadvantage of having a word more.

@jp1ac4 jp1ac4 force-pushed the gui-installer-wording-changes branch from d6bf9ea to f4b4afb Compare November 4, 2024 09:01
@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Nov 4, 2024

will be always able vs will always be able

Oh yes, well spotted :) I changed this to the latter as I think it's more common this way and that's how I kept trying to read it.

nit: titles vs texts are not aligned, and it looks to me the title are too close from the radiuses

I haven't made any changes for this. Shall we move it to a new issue?

I still need to:

* [x]  Update SVGs

SVGs have been updated.

I would use "setup" for consistency with the other introduction pages.

Done.

Looking at it, I would probably drop the "another", especially when adding a key. It was useful to see how it looks, but I don't think it adds much value compared to the disadvantage of having a word more.

I dropped the commit that changed the wording of the "Add key" and "Add recovery option" buttons.

@nondiremanuel
Copy link
Collaborator

nit: titles vs texts are not aligned, and it looks to me the title are too close from the radiuses

I haven't made any changes for this. Shall we move it to a new issue?

Yes we can manage it as a different UI improvement.

@jp1ac4 jp1ac4 marked this pull request as ready for review November 4, 2024 09:46
@pythcoiner
Copy link
Collaborator

updated screenshot @ f4b4afb:
image

image

image
image

image
image

image
image

image

@pythcoiner
Copy link
Collaborator

tACK f4b4afb

@jp1ac4 jp1ac4 force-pushed the gui-installer-wording-changes branch from f4b4afb to 9a3bc87 Compare November 4, 2024 16:54
@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Nov 4, 2024

Rebased on master.

Copy link
Member

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9a3bc87

@edouardparis edouardparis merged commit 30024e5 into wizardsardine:master Nov 4, 2024
31 checks passed
@jp1ac4 jp1ac4 deleted the gui-installer-wording-changes branch November 6, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Wording corrections for installer flow
4 participants