Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lianad: fix check that rescan has started #1506

Merged

Conversation

jp1ac4
Copy link
Collaborator

@jp1ac4 jp1ac4 commented Dec 30, 2024

The startrescan command uses the response from bitcoind's listdescriptors RPC method to confirm that the rescan has started.

This check includes a string comparison that can fail in some cases (Taproot descriptors with a spending path having only a single key) as the descriptor string returned by bitcoind may contain both h and ' , whereas Liana's descriptor string only uses ' (as per the Descriptor::to_string() method).

This PR changes the check to first parse each descriptor string as a Descriptor object to avoid any h / ' mismatch issues.

Parsing the descriptor first will ensure a match is found
regardless of whether bitcoind uses `h` or `'`.
@nondiremanuel nondiremanuel added the Bug Something isn't working as expected label Dec 30, 2024
@pythcoiner
Copy link
Collaborator

pythcoiner commented Jan 2, 2025

tACK 6b914fd w/ this (signet) wallet:

tr([124b2e76/48'/1'/0'/2']tpubDFiSVLQkSqEZCopN3gby4hNDE7PG15mUrA5rjJWcMEzHFRzLY7bNCgeoVewjerasVejUizH7AWiZAZMKc7GWM7e4cj3TpUhsqLpgY3Rikca/<0;1>/*,and_v(v:pk([124b2e76/48'/1'/0'/2']tpubDFiSVLQkSqEZCopN3gby4hNDE7PG15mUrA5rjJWcMEzHFRzLY7bNCgeoVewjerasVejUizH7AWiZAZMKc7GWM7e4cj3TpUhsqLpgY3Rikca/<2;3>/*),older(65535)))#wvchffyz

rescan fail on master & success on 6b914fd

@edouardparis
Copy link
Member

utACK 6b914fd

@edouardparis edouardparis merged commit 31c4955 into wizardsardine:master Jan 2, 2025
24 checks passed
@jp1ac4 jp1ac4 deleted the rescan-fix-desc-comparison branch January 2, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as expected
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants