fix reload of selected psbt after update #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem to be working for me. When I click "Update" on an unsigned PSBT and then insert the signed PSBT in the modal, it still shows the PSBT as unsigned until I go back to the PSBTs list and re-select this PSBT. |
|
Are you using the psbts panels ? |
|
It's on the PSBTs panel. Here's a quick video of what I did: Screencast.from.2025-01-06.09-29-55.webmWhen inserting the signed PSBT, the status shows "Not ready" until I go back to the PSBTs list and select the updated PSBT. |
edouardparis
added a commit
that referenced
this pull request
Jan 6, 2025
86e30d2 fix: merge Taproot sigs when updating PSBT (Michael Mallan) Pull request description: While testing #1513, it became apparent that Taproot signatures were not being merged properly when updating a PSBT. This PR fixes and refactors the code to use the `merge_signatures` function that contains the required logic. ACKs for top commit: edouardparis: utACK 86e30d2 Tree-SHA512: ba07d8d2e612d41a3960c5ce04258775334ca22c5268d51822d4e1fbce9614424937e72e688b6006946064c3c04581c20ca2f159bb1bc2a916d98e7e1ef2dc7b
|
We believe the non updated psbt was fixed by #1519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1505