Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release packaging improvements #610

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Conversation

darosior
Copy link
Member

@darosior darosior commented Aug 14, 2023

This cleans up the MacOS distribution and adds Debian packaging to the release script. This gives users of Debian-based distributions (Ubuntu, etc..) a simple way of installing our software.

Fixes #519.

@darosior
Copy link
Member Author

So i looked into having an Arch package. We could have a PKGBUILD that untars the .deb to distribute a liana-bin package, but that can't be included in our release script (since the PKGBUILD needs to be fetching the .deb from the internet).

Anyways, let's have a package for Debian-based system already. It must be 95% of the desktop distributions used. We can always add other package types (Pacman, RPM) in future releases.

@darosior darosior changed the title WIP: Release packaging improvements Release packaging improvements Aug 16, 2023
@darosior darosior marked this pull request as ready for review August 16, 2023 13:59
@darosior
Copy link
Member Author

Let's not merge this until we are actually release 2.0, since the README would be incorrect for 1.0.

@kloaec
Copy link
Collaborator

kloaec commented Aug 16, 2023

So i looked into having an Arch package. We could have a PKGBUILD that untars the .deb to distribute a liana-bin package, but that can't be included in our release script (since the PKGBUILD needs to be fetching the .deb from the internet).

Anyways, let's have a package for Debian-based system already. It must be 95% of the desktop distributions used. We can always add other package types (Pacman, RPM) in future releases.

While I understand it's hard to track, 95% seems waaaay far off. Manjaro and EndeavourOS are amonst the most popular distros, and are both Arch based. Reality is probably close to 50% Arch based at this stage, especially for newbies (Manjaro especially). Steam survey of last month gives Arch-based more than 50%. https://itsfoss.com/content/images/2023/08/August-2023.png

@darosior
Copy link
Member Author

darosior commented Aug 16, 2023 via email

@pythcoiner
Copy link
Collaborator

Fair enough. I'd be interested in the number of persons polled, but that seems fair (and surprising to me!) numbers. I can have another look at not using makepkg along with a PKGBUILD but instead building the archive manually myself. I'd welcome your input if you have any regarding: - The format of the Pacman package we should distribute. (that's a .pkg.tar.zst right?) - The method of creating a binary Pacman package before having released the other packages.

can have a look about that if it can wait until this week end

@darosior
Copy link
Member Author

We discussed it offline with @kloaec. We'll just push a PKGBUILD to AUR after each release, and not release some sort of package on Github: instead we'll document Arch user can use yum or whatever other wrapper to get Liana from AUR.

Git cannot track empty folders, use an a zip archive for this.
It's now been integrated in our release script.
@darosior
Copy link
Member Author

Rebased and dropped the commit announcing the .deb in the README. Arch packaging was implemented in #614, backported in #616 and the PKGBUILD was pushed to AUR. I think this is good to go, finally. 🎉

@darosior
Copy link
Member Author

ACK 2888db4

@darosior darosior merged commit bdeaf93 into wizardsardine:master Aug 18, 2023
8 of 12 checks passed
@darosior darosior deleted the packaging branch August 18, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer packages for linux
3 participants