commands: include missing amount in spend response #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp1ac4
force-pushed
the
commands-include-missing-in-spend-result
branch
2 times, most recently
from
8cd021d
to
e9e46b1
Compare
The GUI uses the InsufficientFunds error to get the missing amount when the user is creating a new spend. It is not straightforward to extract this information in a general way from the RPC error. Instead, this missing amount will be included in the command response. These changes are based on suggestions from darosior and edouardparis.
jp1ac4
force-pushed
the
commands-include-missing-in-spend-result
branch
from
e9e46b1
to
1339898
Compare
|
re-ACK 1339898 |
edouardparis
added a commit
that referenced
this pull request
Jan 30, 2024
…sing amount cb5073c gui(spend): use create_spend_tx for missing amount (jp1ac4) fae32df gui: pass change_address param to createspend (jp1ac4) Pull request description: This PR is a follow-up to #927 and uses changes made in #938. It reverts to using the `createspend` command in the GUI for automated coin selection and to determine the amount left to select when creating a new spend (which was previously changed in #863). With this PR, the changes from #873 will become effective in the GUI so that (some) unconfirmed coins are used as candidates and any additional fee to pay for ancestors is included when calculating the amount left to select. ACKs for top commit: edouardparis: ACK cb5073c Tree-SHA512: d780b8a0238b595301701d889c45b263682867cdff1ec054872f717de7ae3d325fc5010c8df29333ae2a44ae2e92a86689d332a26ac7334c7e92fd9ffc7a6397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows a discussion around #873 (comment).
The GUI uses the
InsufficientFundserror to get the missing amount when the user is creating a new spend, but it is not straightforward to extract this information in a general way from the RPC error (see #822 (comment)) and instead the spend module'screate_spendis currently used (see #863).With this PR, the missing amount will be included in the
createspendresponse rather than as an error.These changes are based on suggestions from @darosior and @edouardparis.
In a follow-up PR, the GUI should revert to using the
createspendcommand to calculate the amount left to select.