Add addtional check for 404 images

Testing out re issue #207
wjdp · Jan 28, 2023 · 078245d · 078245d
1 parent 11794c5
commit 078245d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/htmltest/check-img_test.go b/htmltest/check-img_test.go
@@ -18,7 +18,16 @@ func TestImageExternalMissing(t *testing.T) {
 		map[string]interface{}{"VCREnable": true})
 	tExpectIssueCount(t, hT, 1)
 	// Issue contains "no such host"
-	// tExpectIssue(t, hT, "no such host", 1)
+	tExpectIssue(t, hT, "no such host", 1)
+}
+
+func TestImageExternal404(t *testing.T) {
+	// fails for missing external images
+	hT := tTestFileOpts("fixtures/images/imageExternal404.html",
+		map[string]interface{}{"VCREnable": true})
+	tExpectIssueCount(t, hT, 1)
+	// Issue contains "no such host"
+	tExpectIssue(t, hT, "Non-OK status: 404", 1)
 }
 
 func TestImageExternalMissingProtocolValid(t *testing.T) {

diff --git a/htmltest/fixtures/images/imageExternal404.html b/htmltest/fixtures/images/imageExternal404.html
@@ -0,0 +1,9 @@
+<html>
+
+<body>
+
+	<p>Blah blah blah. <img alt="A src that'll return 404" src="https://upload.wikimedia.org/wikipedia/en/404" /> </p>
+
+</body>
+
+</html>