Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single page form file restructure #530

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Single page form file restructure #530

wants to merge 4 commits into from

Commits on Oct 24, 2024

  1. Remove single page prefix from components 

    We no longer have a 2-page donation form so this
prefix is now redundant.

Ticket: https://phabricator.wikimedia.org/T378075
    @Abban
    Abban committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    cd18b7f View commit details
    Browse the repository at this point in the history

  2. Silence SASS Deprecation Warnings 

    The version of Bulma we use now uses deprecated sass
functions. We can't update to the next version of Bulma
and we plan to eventually remove it altogether. In the
interim I've turned off deprecation warnings from the
sass compiler. We will eventually need to turn this back
on as our site will break when Dart Sass hits v3.

Ticket: https://phabricator.wikimedia.org/T378075
    @Abban
    Abban committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6bc99ed View commit details
    Browse the repository at this point in the history

  3. Move form functions into DonationForm 

    The donation form being a single page now means that
functions to handle it are in the wrong place. This
moves them to the top level component and passes them
as props into the sections and summaries.

Changelist
- Integrated Street Autocomplete and removed toggles.
- Created sub-pages for the 2 remaining donation forms.
- Moved submit handling out of the data sections and into
  the new sub pages.
- Moved form summary, error summary, and submit buttons into
  a separate form section.
- Moved tests from form sections into donation sub form tests.
- useReceiptModel is shared so moved it into shared/composables.
- Added tests for DonationReceipt AddressFields.
- Moved salutation locale adjustment into the store and added tests.

Ticket: https://phabricator.wikimedia.org/T378075
    @Abban
    Abban committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9d93d94 View commit details
    Browse the repository at this point in the history

  4. Improve alignment on donation form fields 

    We had different widths for each of the different
fields which was making the form look ragged. This
increases the max-width to line them all up.

Also adds flex wrap to the row alignment radio fields
so they don't burst out of the content box.

Ticket: https://phabricator.wikimedia.org/T378075
    @Abban
    Abban committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    90162b9 View commit details
    Browse the repository at this point in the history