Document Database Setup and Migrations #2994
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiikana
reviewed
Oct 8, 2024
moiikana
reviewed
Oct 8, 2024
| The Fundraising Application has two different database environments: | ||
|
|
||
| - The **local development environment**. We're running a MariaDB database in a Docker container for local user and acceptance testing. We are using an in-memory SQLite database for running unit tests. This makes running the tests fast and allows for a clear separation between interactive testing and automated testing. | ||
| - The **server environment** has a dedicated database server with two databases (test and production) that our test and production web servers connect to. The Fundraising App and the Fundraising Operation Center both share the same production or testing database. |
There was a problem hiding this comment.
Suggested change
| - The **server environment** has a dedicated database server with two databases (test and production) that our test and production web servers connect to. The Fundraising App and the Fundraising Operation Center both share the same production or testing database. | |
| - The **server environment** is running on a dedicated database server with two databases (test and production) that our test and production web servers connect to. The Fundraising App and the Fundraising Operation Center both share the same production or testing database. |
There was a problem hiding this comment.
Hmm, maybe "consists of" or just "uses"? Pinging @Abban for a comment
moiikana
reviewed
Oct 8, 2024
moiikana
reviewed
Oct 8, 2024
| If you're getting errors from the application after the containers are up, check if the database tables exist by running the following command: | ||
|
|
||
| ```shell | ||
| docker compose exec database mysql -u fundraising -p"INSECURE PASSWORD" fundraising -e "SHOW TABLES" |
There was a problem hiding this comment.
Suggested change
| docker compose exec database mysql -u fundraising -p"INSECURE PASSWORD" fundraising -e "SHOW TABLES" | |
| docker compose exec database mysql -u fundraising -p "INSECURE PASSWORD" fundraising -e "SHOW TABLES" |
There was a problem hiding this comment.
Nope, this is one of the pecularities of the MySQL client: if you specify -p something it will interpret that as "ask for a password and use parameter 'something'". If its -psomething it will interpret that as "Use password 'something'". And sometimes will give a warning about that practice because that command can then end up in the bash history, revealing the password.
moiikana
reviewed
Oct 8, 2024
| 2. Run CI and fix failing tests. | ||
| 3. Run the database migration on the *old* version of the database schema | ||
| 4. User-test the changed database (to check if the migrated database is correct) | ||
| 5. Re-generate SQL for the local environment. |
There was a problem hiding this comment.
does this point refer to ### Regenerating the local SQL ? Maybe we could link there or add the command here as well
moiikana
requested changes
Oct 8, 2024
Co-authored-by: Co <[email protected]>
Co-authored-by: Co <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to integrate a database change from a bounded context in the Fundraising Application