C24_WMDE_iPad_DE_01 #569
Open
C24_WMDE_iPad_DE_01 #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sperling-0
force-pushed
the
C24_WMDE_iPad_DE_01
branch
2 times, most recently
from
eb4915a
to
5cdbbad
Compare
Sperling-0
force-pushed
the
C24_WMDE_iPad_DE_01
branch
5 times, most recently
from
d4f4209
to
53c3d27
Compare
Abban
approved these changes
Oct 16, 2024
| @@ -5,12 +5,13 @@ | |||
| $select-group-button: true, | |||
There was a problem hiding this comment.
When #579 is merged the payment logos here will break. You should be able to already add $select-group-image-label: true to this list.
| ); | ||
| @use '@src/components/BannerConductor/banner-transition'; | ||
| @use 'Banner'; | ||
| @use 'MainBanner' with ( | ||
| $banner-height: 378px, | ||
| $form-width: 256px | ||
| $form-width: 35% |
There was a problem hiding this comment.
Pixel width is used here is so the form remains consistent on all screen sizes. Is there a reason you changed it to a percentage?
There was a problem hiding this comment.
I did not change it. It came from styles_var.scss of C24_WMDE_iPad_00.
| @@ -42,7 +42,7 @@ $progress-bar-margin: 0 !default; | |||
| &-fill-wrapper { | |||
| position: relative; | |||
| background: var( --progress-bar-wrapper-background ); | |||
| border: 3px var( --progress-bar-wrapper-border ); | |||
| border: 3px var( --progress-bar-wrapper-border ) solid; | |||
There was a problem hiding this comment.
This works, but the general convention for the order when defining border styles is border: <size> <style> <colour>;
border: 3px solid var( --progress-bar-wrapper-border );There was a problem hiding this comment.
This is identical to messages.js so you can delete this and use the same file in both banners.
|
To get the latest UoF working:
|
Sperling-0
force-pushed
the
C24_WMDE_iPad_DE_01
branch
2 times, most recently
from
ff998ac
to
c2d0db9
Compare
✅ Done |
Sperling-0
force-pushed
the
C24_WMDE_iPad_DE_01
branch
10 times, most recently
from
f96a268
to
06d55bf
Compare
|
consider rebasing because #597 got merged |
Sperling-0
force-pushed
the
C24_WMDE_iPad_DE_01
branch
8 times, most recently
from
a3cf5c5
to
491ca47
Compare
- The average donation should be changed from 22,25 € to 22,49 €
- Added space between 99% -> 99 %
- The third option below the two buttons "Ja, ich möchte jährlich spenden, aber einen anderen Betrag." is removed from the 2nd form page.
- The first slide shows the data and time "{{ liveDateAndTime.currentDate }}, {{ liveDateAndTime.currentTime }} - An alle, die Wikipedia in Deutschland nutzen:" and ends with "Unabhängigkeit von Wikipedia zu unterstützen."
- It has the progress bar
- It has the campaign day sentence
- It has the visitors-vs-donors sentence
- It has the soft close
- It has an additional paragraph on the 2nd form page
- It has "I already donated" button in the soft close, respective theme css files have been modified
- Update clean-up-2025 document
Ticket: https://phabricator.wikimedia.org/T376593
Co-authored-by: Abban Dunne <[email protected]>
- The average donation should be changed from 22,25 € to 22,49 €
- Added space between 99% -> 99 %
- The third option below the two buttons "Ja, ich möchte jährlich spenden, aber einen anderen Betrag." is removed from the 2nd form page.
- The first slide shows the data and time "{{ liveDateAndTime.currentDate }}, {{ liveDateAndTime.currentTime }} - An alle, die Wikipedia in Deutschland nutzen:" and ends with "Unabhängigkeit von Wikipedia zu unterstützen."
- The headline of the variant banner is changed
- The amount on the 3rd slide should also be changed from 5 € to 15 €
- The second amount option in the variant banner form should be 15 €
- It has the progress bar
- It has the campaign day sentence
- It has the visitors-vs-donors sentence
- It has "I already donated" button in the soft close
- Update content repo
Ticket: https://phabricator.wikimedia.org/T376593
Co-authored-by: Abban Dunne <[email protected]>
Sperling-0
force-pushed
the
C24_WMDE_iPad_DE_01
branch
from
491ca47
to
55bcf6b
Compare
✅ Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T376593