-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C24_WMDE_Mobile_EN_01 #581
Open
Abban
wants to merge
5
commits into
main
Choose a base branch
from
C24_WMDE_Mobile_EN_01
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abban
force-pushed
the
C24_WMDE_Mobile_EN_01
branch
from
October 18, 2024 04:03
0eb78b7
to
0d13c9e
Compare
To get the latest UoF working:
|
Sperling-0
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments in the ticket.
Abban
force-pushed
the
C24_WMDE_Mobile_EN_01
branch
from
October 22, 2024 05:54
0d13c9e
to
fc865a5
Compare
Abban
force-pushed
the
C24_WMDE_Mobile_EN_01
branch
from
October 25, 2024 12:15
fc865a5
to
eccf752
Compare
needs to be rebased because of #597 |
Abban
force-pushed
the
C24_WMDE_Mobile_EN_01
branch
from
October 25, 2024 13:50
eccf752
to
5761ffd
Compare
We use the page scroller to show the donation form but this doesn't always align to the top. This modifies the behavior to make that happen.
This is a mostly unused icon, so this clears it out of the themes to reduce confusion. Also removes it from the en mobile banners.
Based on ctrl of C23_WMDE_Mobile_EN_02 - Add styles for the upgrade to yearly form - Add event tracking for soft close already donated Ticket: https://phabricator.wikimedia.org/T376794
- Add clickable headline that shows Use of Funds - Add colours for light and dark mode - Add test Ticket: https://phabricator.wikimedia.org/T376794
Abban
force-pushed
the
C24_WMDE_Mobile_EN_01
branch
from
October 25, 2024 16:26
5761ffd
to
cb9a7cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on ctrl of C23_WMDE_Mobile_EN_02
Ticket: https://phabricator.wikimedia.org/T376794