Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C24_WMDE_Mobile_EN_01 #581

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

C24_WMDE_Mobile_EN_01 #581

wants to merge 5 commits into from

Conversation

Abban
Copy link
Member

@Abban Abban commented Oct 15, 2024

Based on ctrl of C23_WMDE_Mobile_EN_02

  • Add styles for the upgrade to yearly form
  • Add event tracking for soft close already donated
  • Add clickable headline that shows Use of Funds
  • Add colours for light and dark mode
  • Add test

Ticket: https://phabricator.wikimedia.org/T376794

@Abban Abban changed the base branch from main to mobile-en-dark-mode October 18, 2024 04:02
@Sperling-0
Copy link
Contributor

⚠️ Rebase this PR from latest main.

To get the latest UoF working:

  • For Desktop banners: BannerCtrl.vue, BannerVar.vue, FallbackBanner.vue needs to be updated. (If it is DE desktop include DE infographic and vice versa)
  • For Mobile/ Ipad banners: BannerCtrl.vue, BannerVar.vue needs to be updated. (If it is DE mobile include DE infographic and vice versa)

Base automatically changed from mobile-en-dark-mode to main October 18, 2024 15:30
Copy link
Contributor

@Sperling-0 Sperling-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments in the ticket.

@moiikana
Copy link
Contributor

needs to be rebased because of #597

We use the page scroller to show the donation form
but this doesn't always align to the top. This modifies
the behavior to make that happen.
This is a mostly unused icon, so this clears it out of the
themes to reduce confusion.

Also removes it from the en mobile banners.
Based on ctrl of C23_WMDE_Mobile_EN_02

- Add styles for the upgrade to yearly form
- Add event tracking for soft close already donated

Ticket: https://phabricator.wikimedia.org/T376794
- Add clickable headline that shows Use of Funds
- Add colours for light and dark mode
- Add test

Ticket: https://phabricator.wikimedia.org/T376794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants