Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow (and enforce) per-campaign tests instead of reusing the same test folder for every new campaign. Add CI check to check if channel name in test folder matches imports in test files, to avoid forgetting to adapt the tests.
Do a daily run of all banner tests to ensure backwards compatibility (we might need to adjust the notification settings for that in a followup PR)
When this is merged and you rebase, you'll have to adjust current PRs to use new structure, otherwise they'll fail.
Ticket: https://phabricator.wikimedia.org/T369276