Skip to content

Commit

Permalink
Bump prettier from 2.8.8 to 3.3.3 (#715)
Browse files Browse the repository at this point in the history
* Bump prettier from 2.8.8 to 3.3.3

Bumps [prettier](https://github.com/prettier/prettier) from 2.8.8 to 3.3.3.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.8...3.3.3)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* remove prettier restriction from chore instructions

Prettier 3 is compatible with the current version of Jest, making
the info in the README obsolete.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Audrey Penven <[email protected]>
  • Loading branch information
dependabot[bot] and yerdua authored Oct 4, 2024
1 parent 6fb1db2 commit 779213f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 14 deletions.
4 changes: 0 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,6 @@ The following dependencies should be ignored:
in production, we use the versions shipped by MediaWiki core,
so we should use the same versions for testing.
The current versions shipped by MediaWiki core are listed in [foreign-resources.yaml](https://gerrit.wikimedia.org/g/mediawiki/core/+/master/resources/lib/foreign-resources.yaml).
- Prettier:
[Jest 29.65.2](https://github.com/jestjs/jest/blob/main/CHANGELOG.md#2962) is not compatible with Prettier 3.
This might be resolved with the next release ([Jest#14566](https://github.com/jestjs/jest/pull/14566)),
so be sure to check whether a newer Jest version is available that includes Prettier 3 compatibility.
- Node.js version:
The GitHub Workflows here should use the same Node.js version as the `mwgate-nodeXX-docker` CI job in WikibaseLexeme,
because that job builds this app for the `test:snl-distnodiff` script. This version is currently Node 18.
Expand Down
18 changes: 9 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"lint-staged": "^15.2.10",
"lodash": "^4.17.21",
"npm-run-all": "^4.1.5",
"prettier": "^2.8.8",
"prettier": "^3.3.3",
"sass": "^1.77.8",
"start-server-and-test": "^2.0.5",
"stylelint": "^16.9.0",
Expand Down

0 comments on commit 779213f

Please sign in to comment.