Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Codex Field + TextInput instead of Wikit TextInput #765

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Use Codex Field + TextInput instead of Wikit TextInput #765

merged 2 commits into from
Sep 25, 2024

Commits on Sep 23, 2024

  1. Use Codex Field + TextInput instead of Wikit TextInput 

    Change the lemma to not use Wikit anymore. In Codex, this corresponds to
two components, so use both.

The spacing of the “required” asterisk is done differently – it’s no
longer in a flex container, so establish the spacing using margin
instead. The asterisk is now also part of the actual <label> element,
which isn’t ideal but I think can’t be avoided within Codex. (Note that
Codex doesn’t want us to indicate required fields at all; see also
T374432.)

Bug: T370054
    @lucaswerkmeister
    lucaswerkmeister committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c641ffd View commit details
    Browse the repository at this point in the history

  2. Restructure error computation 

    Since Codex wants the status and messages as separate props, but we
compute them at the same time, let’s have the computed return an object
with both props.

Bug: T370054
    @lucaswerkmeister
    lucaswerkmeister committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    318077e View commit details
    Browse the repository at this point in the history