Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vue version #777

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Fix Vue version #777

merged 3 commits into from
Oct 17, 2024

Conversation

lucaswerkmeister
Copy link
Member

See individual commit messages. (Reverts #774.)

@github-actions GitHub Actions
Copy link

https://45a938c841fa55ded03c390d9cc53f4311db--new-lexeme-special-page.netlify.app

@lucaswerkmeister lucaswerkmeister mentioned this pull request Oct 16, 2024
Closed
yerdua
yerdua previously approved these changes Oct 16, 2024
View reviewed changes
@lucaswerkmeister
Restore @vue/compiler-dom to 3.4.27
6891480 
This effectively reverts #774 (commit 0656354) and part of #778
(commit 4d91a4e) – we want to stay on the same Vue version as
MediaWiki core (see README).
@lucaswerkmeister
Remove Vue updates from Dependabot
6db8d29 
Per the README, we want to keep using the same Vue version as MediaWiki
core, so let’s disable Dependabot updates for these packages.
@lucaswerkmeister
Copy link
Member Author

Updated after conflicts (I ended up just recreating the first commit from scratch).

@lucaswerkmeister
Copy link
Member Author

Wondering if we should also pin the versions in package.json as 3.4.27 rather than ^3.4.27…

@yerdua
Copy link
Contributor

yerdua commented Oct 17, 2024

Wondering if we should also pin the versions in package.json as 3.4.27 rather than ^3.4.27…

Makes sense to me. Is there any harm in doing so?

@lucaswerkmeister
Copy link
Member Author

Don’t think so, I just didn’t think of it yesterday and then thought of it today while idly staring at the terminal output from yesterday ^^ I’ll update the PR.

@lucaswerkmeister
Pin Vue versions in package.json
5274cb1 
Since we want these versions to be exact, let’s not use the caret
operator.
@lucaswerkmeister
Copy link
Member Author

Ended up putting it in a separate commit because I didn’t think it really fit into either of the existing ones.

@yerdua yerdua merged commit 147eabf into main Oct 17, 2024
2 checks passed
@yerdua yerdua deleted the vue-version branch October 17, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yerdua yerdua yerdua approved these changes

@codders codders Awaiting requested review from codders

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucaswerkmeister @yerdua