Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cleanup): recaptcha values #1171

Merged
merged 4 commits into from
Sep 19, 2023
Merged

chore(cleanup): recaptcha values #1171

merged 4 commits into from
Sep 19, 2023

Conversation

deer-wmde
Copy link
Contributor

@deer-wmde deer-wmde commented Sep 19, 2023 •
edited
Loading

This PR cleans up some value files

  • prod: api: sitekeySecretName gets removed (only UI needs it)
  • local & staging: api: recaptcha3 secret secret name gets read from private.yaml
  • local: external block from api.values gets removed - honestly idk why it was even there
  • local: ui: recaptcha3 site secret name gets read from private.yaml
  • local: mw: recaptcha2 secrets name gets read from private.yaml
  • local: rename recaptcha secrets to match staging/prod (recaptcha-vN-secrets vs recaptcha-vN-dev-secrets)
    • this will require to update your tfvars files

tarrow
tarrow approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably at some point we ought to just give all these secrets the same name in all environments but whatever ;)

@deer-wmde
Copy link
Contributor Author

Probably at some point we ought to just give all these secrets the same name in all environments but whatever ;)

yeah I wanted to include that, but it's in the terraform modules... which is the same repo I now realize. Will add

@deer-wmde deer-wmde merged commit f9f6332 into main Sep 19, 2023
2 checks passed
@deer-wmde deer-wmde deleted the de/230919/recaptcha-cleanup branch September 19, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrow tarrow tarrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deer-wmde @tarrow