fix(build): always tag image versions

[rti]

Before, local and ci builds would not tag image versions, just latest. This lead to e.g. deploy not picking up local builds. With this change, images get always tagged with versions numbers, regardless of where they are built.

[lorenjohnson]

The reasoning behind not tagging the version until we have specifically decided to publish as a safeguard somewhat from different builds with the same version numbers floating around. I do still prefer it that way, but it does of course means we don't automatically use local builds when running deploy. I think we should look at how to solve that a different way and keep the version tagging as a publish event.

[rti]

I see, thanks for your response. I understand that reasoning. I'd still like to noodle a bit on that topic, because I personally see pros in both approaches.

[lorenjohnson]

I see, thanks for your response. I understand that reasoning. I'd still like to noodle a bit on that topic, because I personally see pros in both approaches.

Noodle away :) Here are a couple additional thoughts on this:

Multi-platform builds can't be stored locally, so if/when we go there tagging a local build that is not multi-platform could be trouble making. Having our workflow ensure that there is only one "authoritative" version under any version tag is worth prioritising I think, and central to why I see version tagging as a push/publish activity.

If we need to test against previous built versions I think we should be pulling them from the registry. Perhaps our pre-releases should go up to the registry as well to cover the gray areas--like not every local build--but ones in release testing vs active development.