Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wikibase): bump mediawiki to 1.39.10, bump extensions #781

Open
wants to merge 3 commits into
base: MediaWiki-1.39
Choose a base branch
from

Conversation

rti
Copy link
Contributor

@rti rti commented Oct 2, 2024

No description provided.

@rti rti requested a review from a team October 2, 2024 13:40
@rti rti marked this pull request as draft October 2, 2024 13:40
@lorenjohnson lorenjohnson changed the base branch from main to MediaWiki-1.39 October 9, 2024 10:02
@lorenjohnson lorenjohnson marked this pull request as ready for review October 9, 2024 10:09
@lorenjohnson
Copy link
Contributor

Created a MediaWiki-1.39 branch off the head of main for now, and rebased this off that branch. That works fine, and I think is a good way to go about this.

Interesting though, when I run ./nx release -p wikibase --dry-run on this I get version 3.0.1, which is expected as we only have chores and fixes. We actually want to move to 1.1.0 as it's a MediaWiki patch and we decided to always move up minor versions as patch versions from MediaWiki aren't guaranteed to be just bug fixes, but include features sometimes... That aside, the release command also didn't catch the chore(wikibase): ... commit in the CHANGELOG and not sure immediately why. All the same for the other updated PR. Will explore more.

@lorenjohnson
Copy link
Contributor

Ah right, we need this from the Initial Releases branch in order for chore to actually be a CHANGELOG type, it is actually off by default: https://github.com/wmde/wikibase-release-pipeline/blob/953b5798a7e67db641be814b2907d3fbe326fd49/nx.json

@lorenjohnson
Copy link
Contributor

@rti because MediaWiki updates are always considered to be Minor release due to potential new features we should conventional commit with "feat:" to get the right versioning automatically here. Going to re-write history here and on the other bump branch to reflect that.

@lorenjohnson lorenjohnson force-pushed the prepare-wikibase-1.39.10 branch 2 times, most recently from 001bfb5 to 54c5ed5 Compare October 9, 2024 10:58
@rti
Copy link
Contributor Author

rti commented Oct 14, 2024

@lorenjohnson I do remember us gravitating towards
"patch mediawiki version bumps are minor versions" but I think it is not necessary. Rereading https://www.mediawiki.org/wiki/Version_lifecycle I now think we are pretty save calling it a patch release:

[...] release branches continue to receive security updates for up to a year as of first release.

Every point release will include updated i18n files as well as any bug fixes. No new features will be back-ported to point releases [...]

@lorenjohnson
Copy link
Contributor

@lorenjohnson I do remember us gravitating towards "patch mediawiki version bumps are minor versions" but I think it is not necessary. Rereading https://www.mediawiki.org/wiki/Version_lifecycle I now think we are pretty save calling it a patch release:

Fine by me, with a small question of whether the current version also doesn't get any new features in the point releases? Either way, shouldn't change this PR.

@rti
Copy link
Contributor Author

rti commented Oct 15, 2024

Fine by me, with a small question of whether the current version also doesn't get any new features in the point releases?

Yes, this is how I read it. From WMF perspective, all stable versions are not current anymore because they mainly care about main for production deployments.

Either way, shouldn't change this PR.

I think we should make sure that no commit mentions feat: then.

@lorenjohnson
Copy link
Contributor

I think we should make sure that no commit mentions feat: then.

Ok, I've changed that feat: commit to be a chore both here and on the other legacy branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants