Allow using QGuiApplication and not linking to QtWidgets
#211
Conversation
…` instead of `QApplication`
qttypes/Cargo.toml
Outdated
| @@ -31,6 +31,8 @@ qtmultimediawidgets = [] | |||
| qtsql = [] | |||
| # Link against QtTest | |||
| qttest = [] | |||
| # Don't link QtWidgets and use QGuiApplication | |||
| nowidgets = [] | |||
There was a problem hiding this comment.
In Rust, features need to be additive.
So this should be a qtwidget feature and enable it by default.
There was a problem hiding this comment.
But then what about users who already have no-default-features enabled? It would break the build for them
There was a problem hiding this comment.
Right.
I suppose we will have to increase the semver then.
There was a problem hiding this comment.
Something like rust-lang/rfcs#3146 would be nice.
It's not super important, it'll be just nice to save some space by not having to deploy QtWidgets module when it's not used. It can wait, it's not a blocker for me |
qmetaobject/Cargo.toml
Outdated
| chrono_qdatetime = ["qttypes/chrono"] | ||
| webengine = ["qttypes/qtwebengine"] | ||
| widgets = ["qttypes/qtwidgets"] | ||
|
|
||
| [dependencies] | ||
| qttypes = { path = "../qttypes", version = "0.2.5", features = ["qtquick"] } |
There was a problem hiding this comment.
| qttypes = { path = "../qttypes", version = "0.2.5", features = ["qtquick"] } | |
| qttypes = { path = "../qttypes", version = "0.2.5", default-features = false, features = ["required", "qtquick"] } |
This PR is extremely helpful for me: I'm creating an app for the reMarkable e-ink tablet, which only supports QtQuick. However, qttypes still tries to link to QtWidgets with its default features, which causes an error for me because it doesn't exist.
… as supported, but it's required on Android so add it explicitly
…detected as supported, but it's required on Android so add it explicitly" This reverts commit e359084.
|
Maybe it's soon time to make a breaking change release so we can merge this. |
This PR adds a new feature flag that allows to skip linking the QtWidgets module and use
QGuiApplicationinstead ofQApplication. I added it as an optional feature that disables the linking to not break any existing code and feature set that users may already have.