Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spelling and grammatical error #550

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

spelling and grammatical error #550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ There are also some built in 'views' that will create a special column. For exa

{ view: "increment" , label: false , text: "+" }

will have a link that increments the quantity. Setting the `label:false` will hide the label for the view. You can specify the text of the link with that `text:` attribute.
will have a link that increase the quantity. Setting the `label:false` will hide the label for the view. You can specify the text of the link with that `text:` attribute.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, this is not a correction of spelling OR grammar. You have actually MADE a grammar error in your poor attempt at correction, and shown a lack of understanding.

"Increments" is correct. While you could substitute "increases" for some loss of domain specific meaning, you cannot substitute "increase" which is grammatically INCORRECT.

Trivial PRs like this can be annoying, but when they are wrong, they are more than annoying. If you want to correct someone's English, make sure you know enough to do so!


You can add `view: "currency"` to format the column as currency (see the currency section on more information on currency formatting).

Expand Down