array items fake to be required to ensure null-safe checks to not enf…

…orce each place implementing checks to handle array items specifically. Don't pollute the PropertyMetaDataCollection (which is now used to generate a cache key for properties) with this information as the items aren't really required.

src/Model/Property/Property.php

@@ -288,7 +288,7 @@ public function getDefaultValue(): ?string
      */
     public function isRequired(): bool
     {
-        return $this->isPropertyRequired;
+        return $this->isPropertyRequired || str_starts_with($this->name, 'item of array ');
     }
 
     /**

src/Model/Validator/ArrayItemValidator.php

@@ -43,7 +43,7 @@ public function __construct(
         // an item of the array behaves like a nested property to add item-level validation
         $this->nestedProperty = (new PropertyFactory(new PropertyProcessorFactory()))
             ->create(
-                new PropertyMetaDataCollection([$nestedPropertyName]),
+                new PropertyMetaDataCollection(),
                 $schemaProcessor,
                 $schema,
                 $nestedPropertyName,

src/PropertyProcessor/Property/AbstractPropertyProcessor.php

@@ -48,7 +48,7 @@ protected function generateValidators(PropertyInterface $property, JsonSchema $p
             $this->addDependencyValidator($property, $dependencies);
         }
 
-        if ($property->isRequired()) {
+        if ($property->isRequired() && !str_starts_with($property->getName(), 'item of array ')) {
             $property->addValidator(new RequiredPropertyValidator($property), 1);
         }
 

src/PropertyProcessor/Property/ArrayProcessor.php

@@ -234,21 +234,16 @@ private function addContainsValidation(PropertyInterface $property, JsonSchema $
             return;
         }
 
-        $name = "item of array {$property->getName()}";
         // an item of the array behaves like a nested property to add item-level validation
         $nestedProperty = (new PropertyFactory(new PropertyProcessorFactory()))
             ->create(
-                new PropertyMetaDataCollection([$name]),
+                new PropertyMetaDataCollection(),
                 $this->schemaProcessor,
                 $this->schema,
-                $name,
+                "item of array {$property->getName()}",
                 $propertySchema->withJson($propertySchema->getJson()[self::JSON_FIELD_CONTAINS]),
             );
 
-        $nestedProperty->filterValidators(static fn(Validator $validator): bool =>
-            !is_a($validator->getValidator(), RequiredPropertyValidator::class)
-        );
-
         $property->addValidator(
             new PropertyTemplateValidator(
                 $property,