Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openvswitch (ovs) port. #117

Closed
wants to merge 1 commit into from

Conversation

haydenroche5
Copy link
Contributor

No description provided.

Copy link
Contributor

@LinuxJedi LinuxJedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes, but looking good.

automatically build with support for it.

+- libwolfssl, from wolfSSL, is optional and can be used instead of openssl to
+ provide commercial open source library for TLS and Crypto. Enabled using
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably change this to "provide commercial and open source libraries". Can maybe say "as an alternative to" instead of "instead of".

- * CA certificate on its first connection. */
void
-stream_ssl_set_peer_ca_cert_file(const char *file_name)
+stream_ssl_set_peer_ca_cert_file__(const char *file_name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably get rid of the static declaration above as it isn't called before this implementation and the static keyword needs adding here.

+
+dnl Checks for wolfSSL
+AC_DEFUN([OVS_CHECK_WOLFSSL], [
+ WOLFSSL_URL="http://www.wolfssl.com/download.html"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https probably more appropriate for an SSL library :)

@LinuxJedi LinuxJedi assigned haydenroche5 and unassigned LinuxJedi Jun 9, 2022
@JacobBarthelmeh
Copy link
Contributor

#149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants