Initial wolfSSH Espressif Component Publish #599
Conversation
| apps/wolfssh/wolfssh | ||
| apps/wolfsshd/wolfsshd | ||
| apps/wolfsshd/test/test_configuration | ||
|
|
||
| # wolfMQTT examples |
There was a problem hiding this comment.
Why are these in the wolfSSH project?
There was a problem hiding this comment.
There might be value in having a consistent .gitignore across repos? I found myself copying and pasting various exclusions.
| @@ -48,19 +56,34 @@ tags | |||
| diff | |||
| .vimrc | |||
|
|
|||
| # examples | |||
| # wolfSSL examples | |||
There was a problem hiding this comment.
Should be "wolfSSH examples".
| # Eclipse | ||
| *.trs | ||
| firmware.bin | ||
| wolfmqtt/options.h |
There was a problem hiding this comment.
This is wolfSSH not wolfMQTT.
| @@ -0,0 +1,111 @@ | |||
| # | |||
| # Copyright (C) 2006-2022 wolfSSL Inc. All rights reserved. | |||
There was a problem hiding this comment.
And this is the commercial licensing header. Everything in wolfSSH must be GPLv3.
| **/*.vgdbproj.*.user | ||
|
|
||
|
|
||
| # Espressif sdk config default should be saved in sdkconfig.defaults |
There was a problem hiding this comment.
The following items are pathed from root, not local to the git repo, why are they here? Git shouldn't see these.
There was a problem hiding this comment.
I'm pretty sure "root" (leading /) with respect to a GitHub repo directory, means "root of repo", not root of file system, no?
| @@ -0,0 +1,818 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This script is touching things in the wolfMQTT directory, wolfSSH doesn't have that.
There was a problem hiding this comment.
It is a parameterized, universal script: the same for wolfSSL, wolfSSH, and wolfMQTT.
Perhaps an argument for a repo of it's own.
| @@ -0,0 +1,354 @@ | |||
|
|
|||
There was a problem hiding this comment.
Why is the GPLv2 in here? wolfSSH is GPLv3.
There was a problem hiding this comment.
This component install was copied & modified from wolfSSL. I missed the GPLv3 for wolfSSL vs GPLv2 wolfSSL
|
|
||
| # Licensing and Support | ||
|
|
||
| wolfSSL (formerly known as CyaSSL) and wolfCrypt are either licensed for use |
|
|
||
| # Licensing and Support | ||
|
|
||
| wolfSSL (formerly known as CyaSSL) and wolfCrypt are either licensed for use |
|
I'm revising the publishing & moving to scripts. See also wolfSSL/wolfssl#6708 |
This is a replacement PR for #598 that was inadvertently created on an improper repo branch.
Similar to wolfSSL/wolfssl#6708 these are the files used to publish wolfSSH as a component to the Espressif Component Registry. There are also some changes to the
.gitignorefile.These files are not part of wolfSSH library and are only needed to publish wolfSSH to the Espressif ESP Registry:
https://components.espressif.com/components?q=namespace:wolfssl (wolfSSH not yet deployed to production site).
The staging site is at:
https://components-staging.espressif.com/components/gojimmypi/mywolfssh
Note that for the staging site, I have implemented user-specific namespace support in the install script (in my case:
gojimmypiand detected with the$USERvariable). Additionally, on the staging site components are renamed with amyprefix, to distinguish from production libraries. This allows multiple publishers to publish their own test components individually before using the single productionwolfsslnamespace and component names. This also aids in support identification if a customer is using experimental staging components.Only Linux bash script is implemented at this time for publishing.
See the
README.mdfor details. See also #588 and wolfSSL/wolfMQTT#352The recent updates here include support for the staging site and passing a parameter as to the source code to install:
See the
INSTALL.mdfor files to edit for published version specification and other details.Closes #588 and partially addresses #428 (a different
CMakeLists.txtis needed for non-managed components). PR for that soon in separate examples.