Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wolfcrypt/settings.h: use default realloc on EspressIf #6210

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

rizlik
Copy link
Contributor

@rizlik rizlik commented Mar 20, 2023

Description

use default realloc on EspressIf

Fixes: #6201

@gojimmypi
Copy link
Contributor

Thank you @rizlik for the heads-up on this change as related to #6201 from @PaulMartinsen.

I've been able to reproduce the problem and confirmed that your fix works properly on the Espressif ESP-IDF for the ESP32.

I've confirmed that void* realloc(void* ptr, size_t size) is implemented in the Espressif components/newlib/heap.c for ESP-IDF v5. It is also implemented in the same place for EDP-IDF v4.

I've tested this with SINGLE_THREADED both defined or not. I then tested with OPENSSL_EXTRA enabled or not. In all cases the Espressif wolfssl tests on my ED25519_SHA2_fix branch all succeeded.

Note that some combinations on the current wolfSSL release will not work, such as the ED25519 problems noted in #5948 that are fixed in my branch. PR coming as soon as I can clean everything up & complete more testing.

@gojimmypi gojimmypi marked this pull request as ready for review March 20, 2023 23:30
Copy link
Contributor

@gojimmypi gojimmypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change. Not sure I can be the final approver on this; may wish to confirm with @dgarske

gojimmypi added a commit to gojimmypi/wolfssl that referenced this pull request Mar 20, 2023
@rizlik
Copy link
Contributor Author

rizlik commented Mar 23, 2023

This now passes all the tests

@rizlik rizlik assigned dgarske and unassigned gojimmypi Mar 23, 2023
@dgarske dgarske merged commit 85e8274 into wolfSSL:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: XREALLOC implicit definition compile error
3 participants