Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Espressif refactor WROOM32 ESP32 #6587

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

gojimmypi
Copy link
Contributor

Description

This update is preparation to an upcoming large update to the Espressif codebase. Addressed here is only the refactor of macro names as related to the WROOM keyword.

When first implemented, we never imagined there would be such a variety of ESP32 devices and arhcitectures. Many of the new ones have no reference at all to the WROOM product line.

Included is only a global file update of all wolfSSL repo files selected with this selection:

*.md;*.c;*.h;!*/dist/*;!*/managed_components/*;!*/component-manager/*;!*/.git/*;!*/XXX-fips-test/*;

These replacements were made in this order:

Step Replace With
1 WOLFSSL_ESPWROOM32SE $$KEEP__ESP32SE$$
2 WOLFSSL_ESPWROOM32 WOLFSSL_ESP32
3 ESP32WROOM32 ESP32
4 $$KEEP__ESP32SE$$ WOLFSSL_ESPWROOM32SE

Note that WOLFSSL_ESPWROOM32SE names a specific board and is retained.

Any legacy use of the WOLFSSL_ESPWROOM32 is handled in the settings.h file.

See also the changes in #6565 that will be needed for the upcoming PR.

Fixes zd# n/a

Testing

How did you test?

Confirmed wolfssl_test and benchmark examples working properly for ESP32 targets.

Confirmed Linux builds & examples apps:

make clean && make
./wolfcrypt/test/testwolfcrypt 
 wolfcrypt/benchmark/benchmark

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

See #6234 for a roadmap of all Espressif improvements current in progress.

@gojimmypi
Copy link
Contributor Author

I believe the PRB master job failure is unrelated to the changes in this PR.

@dgarske dgarske self-assigned this Jul 10, 2023
@dgarske
Copy link
Contributor

dgarske commented Jul 10, 2023

Retest this please

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup on the macros. The table in the PR is helpful. You should also update the ESP32 documentation as a next step.

@dgarske dgarske merged commit e4c9a73 into wolfSSL:master Jul 10, 2023
gojimmypi added a commit to gojimmypi/wolfssl that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants